Regression fix: add profiles/ prefix to profile filenames #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
force-pushed
the
issue-1364-profiles-prefix
branch
from
8d98baa to
c0b34c4
Compare
ikreymer
reviewed
Nov 10, 2023
backend/btrixcloud/migrations/migration_0021_profile_filenames.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1364
Regression fix for issue introduced in storage refactoring (see issue for more details).
Changes:
profiles/prefix to profile filename passed in to crawler for profile creation and written into dbprofiles/prefix from crawler YAMLprofiles/prefix to profile filenames that don't already have itThis way between the related storage document and the profile filename, we have the full path to the object in the database rather than relying on additional prefixes hardcoded into k8s job YAML files.
Note that this as a follow-up it'll be necessary to manually move any profiles that had been written into the
<oid>"directory" in object storage rather than<oid>/profilesto the latter. This should only affect profiles created very recently in a 1.8.0-beta release.Manually tested but please double check my work!