Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button reworks and navigation updates #2344

Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1e2a590
feat: Update references to org public profile -> gallery (#2330)
SuaYoo Jan 27, 2025
4b627e3
Remove duplicate dialogue actions from collections
Shrinks99 Jan 28, 2025
012b9d3
Add remaining icon buttons
Shrinks99 Jan 28, 2025
e07922d
Remove share item from menu
Shrinks99 Jan 28, 2025
cb9dc7f
Remove button group
Shrinks99 Jan 28, 2025
57c4089
Move edit button for logged in users
Shrinks99 Jan 28, 2025
9f27135
fix eslint error
Shrinks99 Jan 28, 2025
a0d5035
Add dashboard link
Shrinks99 Jan 28, 2025
4a5ed2f
Simplify collection grid action dropdown → edit button
Shrinks99 Jan 28, 2025
8cf56fd
Button casing & consistency fixes
Shrinks99 Jan 28, 2025
e36a67f
Align pageHeader actions to bottom of container
Shrinks99 Jan 28, 2025
e663c0f
Adds org description and url to dashboard
Shrinks99 Jan 28, 2025
4458ae9
Re-remove duped menu item
Shrinks99 Jan 28, 2025
756eebd
Restore pencil and fix primary action buttons
Shrinks99 Jan 28, 2025
e866ca4
Remove view public button from share-collection
Shrinks99 Jan 29, 2025
d18339d
feat: Update references to org public profile -> gallery (#2330)
SuaYoo Jan 27, 2025
24ae991
Remove duplicate dialogue actions from collections
Shrinks99 Jan 28, 2025
f687ba9
Add remaining icon buttons
Shrinks99 Jan 28, 2025
8d34347
hook up edit button to edit dialog
emma-sg Jan 29, 2025
4944dd9
wip: broken logic for moving public collection view to top right
Shrinks99 Jan 29, 2025
1b0802e
refactor shareLink into separate fn
emma-sg Jan 29, 2025
3ca6726
Remove view public from share-collection controls
Shrinks99 Jan 29, 2025
594569b
temp: Move collection gallery link to icon button
Shrinks99 Jan 29, 2025
2eb4881
lint & format
emma-sg Jan 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hook up edit button to edit dialog
emma-sg committed Jan 29, 2025

Verified

This commit was signed with the committer’s verified signature.
luciorq Lucio Queiroz
commit 8d34347e8003aec99316d4c6d7c0a4f6fe767707
10 changes: 8 additions & 2 deletions frontend/src/features/collections/collections-grid.ts
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@ export class CollectionsGrid extends BtrixElement {
html`<btrix-collection-edit-dialog
.collectionId=${this.collectionBeingEdited ?? undefined}
?open=${!!this.collectionBeingEdited}
@sl-hide=${() => {
@sl-after-hide=${() => {
this.collectionBeingEdited = null;
// TODO propagate an event back up & refresh collections
// void this.fetchCollection();
@@ -122,7 +122,13 @@ export class CollectionsGrid extends BtrixElement {
<div class="pointer-events-none absolute left-0 right-0 top-0 aspect-video">
<div class="pointer-events-auto absolute bottom-2 right-2">
<btrix-button raised>
<sl-icon label=${msg("Edit Collection")} name="pencil"></sl-icon>
<sl-icon
label=${msg("Edit Collection")}
name="pencil"
@click=${() => {
this.collectionBeingEdited = collection.id;
}}
></sl-icon>
</btrix-button>
</div>
</div>