-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add development section on dropdown action order #2429
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,21 @@ | |||
# Actions Dropdowns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might call this "Action Menus"?
Actions related only to the current page (eg: remove archived item from collection) | ||
--- | ||
Actions related to editing the object (eg: edit workflow config, edit item metadata) | ||
Other actions related to the current object (eg: run crawl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also be worth including navigation to related items here, like we do for archived items where you can go to the related workflow from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real answer here is they should be discouraged! Will note that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah? I could see it being useful sometimes. Maybe we have a consistent submenu for related items? Go To Related > Workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're considered a (in my opinion small) accessibility sin: https://www.makethingsaccessible.com/guides/site-navigation-is-not-an-aria-menu/
Not bad enough that we should never ever do it, but bad enough that it should be avoided.
Closes #2428
Caveats