-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable winuwp_h264 build for win target #110
base: releases/m71
Are you sure you want to change the base?
Enable winuwp_h264 build for win target #110
Conversation
@SergioOpenPeer my only concern would be how to push back to google since I don't know they would want to build this by default and we may need a compilation option for it... but I don't know we can easily add an args.gn for it easily in a way that would be acceptable to push back. So we need to discuss more on how to accept it and push it back upstream. |
Do they have functionality in their code that is bound to a specific Windows version at compile time? |
@Holo-Krzysztof the WebRTC targets a much lower platform versions. It would likely need to be a flag to specify this code to be compiled or not, and then there's the question of how the code would get integrated and used into the built output result. |
What about adding a "Microsoft/Win10-specific" build flag? There's |
adding the codec properties resolves the issue add h264 profiles to winuwp_h264_factory.cc
|
hello , Can you help me , How to integrate BWE mode into webrtc-uwp-sdk. |
Fixes #109.
I haven't tested it at runtime yet due to our test app being UWP for the moment, but it builds fine.