Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable winuwp_h264 build for win target #110

Open
wants to merge 1 commit into
base: releases/m71
Choose a base branch
from

Conversation

Holo-Krzysztof
Copy link

Fixes #109.

I haven't tested it at runtime yet due to our test app being UWP for the moment, but it builds fine.

@robin-raymond
Copy link
Contributor

@SergioOpenPeer my only concern would be how to push back to google since I don't know they would want to build this by default and we may need a compilation option for it... but I don't know we can easily add an args.gn for it easily in a way that would be acceptable to push back. So we need to discuss more on how to accept it and push it back upstream.

@Holo-Krzysztof
Copy link
Author

Do they have functionality in their code that is bound to a specific Windows version at compile time?

@robin-raymond
Copy link
Contributor

@Holo-Krzysztof the WebRTC targets a much lower platform versions. It would likely need to be a flag to specify this code to be compiled or not, and then there's the question of how the code would get integrated and used into the built output result.

@Holo-Krzysztof
Copy link
Author

What about adding a "Microsoft/Win10-specific" build flag? There's build_with_mozilla for Firefox, so it wouldn't be without precedent.

@ispysoftware
Copy link

ispysoftware commented Nov 24, 2019

i integrated these changes in m75 - it builds but it doesn't work, in media/base/codec.cc:

image

this is returning false because the params2 object is empty

@ispysoftware
Copy link

adding the codec properties resolves the issue

add h264 profiles to winuwp_h264_factory.cc

supported_codecs.push_back(
        SdpVideoFormat(cricket::kH264CodecName,
                       {{cricket::kH264FmtpProfileLevelId, "42100b"},
                        {cricket::kH264FmtpLevelAsymmetryAllowed, "1"},
                        {cricket::kH264FmtpPacketizationMode, "0"}}));
    supported_codecs.push_back(
        SdpVideoFormat(cricket::kH264CodecName,
                       {{cricket::kH264FmtpProfileLevelId, "42100b"},
                        {cricket::kH264FmtpLevelAsymmetryAllowed, "1"},
                        {cricket::kH264FmtpPacketizationMode, "1"}}));

@kzq0717
Copy link

kzq0717 commented May 28, 2021

hello , Can you help me , How to integrate BWE mode into webrtc-uwp-sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants