Give ability to measure decibels full scale and manual control about … #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microphone recording to the app.
This was referenced Nov 10, 2017
Open
tylergibson
pushed a commit
to tylergibson/webrtc
that referenced
this pull request
Feb 12, 2018
…(patchset webrtc-uwp#4 id:60001 of https://codereview.webrtc.org/3002663002/ ) Reason for revert: Breaks Chromium bots. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/27340/steps/generate_build_files/logs/stdio Original issue's description: > Make it possible for tests to set up trace event handlers. > > As it is now, the first time a TRACE_EVENT... is called, the result from > the current handler is stored in a static const variable, and subsequent > calls will use that value regardless of changes to the handler. > > This is a problem if a test wants to use another handler. > > BUG=None > > Review-Url: https://codereview.webrtc.org/3002663002 > Cr-Commit-Position: refs/heads/master@{#19382} > Committed: https://chromium.googlesource.com/external/webrtc/+/a9732656221e0033ab93ecf01cf07f71817da1e8 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2997963002 Cr-Commit-Position: refs/heads/master@{#19383}
tylergibson
pushed a commit
to tylergibson/webrtc
that referenced
this pull request
Feb 12, 2018
…(patchset #1 id:1 of https://codereview.webrtc.org/2997963002/ ) Reason for revert: This should fix it Original issue's description: > Revert of Make it possible for tests to set up trace event handlers. (patchset webrtc-uwp#4 id:60001 of https://codereview.webrtc.org/3002663002/ ) > > Reason for revert: > Breaks Chromium bots. > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/27340/steps/generate_build_files/logs/stdio > > Original issue's description: > > Make it possible for tests to set up trace event handlers. > > > > As it is now, the first time a TRACE_EVENT... is called, the result from > > the current handler is stored in a static const variable, and subsequent > > calls will use that value regardless of changes to the handler. > > > > This is a problem if a test wants to use another handler. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/3002663002 > > Cr-Commit-Position: refs/heads/master@{#19382} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a9732656221e0033ab93ecf01cf07f71817da1e8 > > [email protected],[email protected],[email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2997963002 > Cr-Commit-Position: refs/heads/master@{#19383} > Committed: https://chromium.googlesource.com/external/webrtc/+/db758c2589a983a7dd94dfdd9272892e28251fe4 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2995123002 Cr-Commit-Position: refs/heads/master@{#19386}
tylergibson
pushed a commit
to tylergibson/webrtc
that referenced
this pull request
Feb 12, 2018
…-thread (patchset webrtc-uwp#4 id:200001 of https://codereview.webrtc.org/3005153002/ ) Reason for revert: Landed without CQ, which was unintended. Original issue's description: > Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #1 id:1 of https://codereview.webrtc.org/3010143002/ ) > > Reason for revert: > I will fix and reland. > > Original issue's description: > > Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ ) > > > > Reason for revert: > > Breaks google3 project. > > > > Original issue's description: > > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread > > > > > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue. > > > > > > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > > > > > Review-Url: https://codereview.webrtc.org/3007473002 > > > Cr-Commit-Position: refs/heads/master@{#19666} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598 > > > > [email protected],[email protected],[email protected] > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > > > Review-Url: https://codereview.webrtc.org/3010143002 > > Cr-Commit-Position: refs/heads/master@{#19672} > > Committed: https://chromium.googlesource.com/external/webrtc/+/3eac8002db8fdf5124026d5377a1f3ec1d16bb0d > > [email protected],[email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > Review-Url: https://codereview.webrtc.org/3005153002 > Cr-Commit-Position: refs/heads/master@{#19690} > Committed: https://chromium.googlesource.com/external/webrtc/+/d67cefbbeab0a092d1fa250c811c25733dced043 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8142, webrtc:8143, webrtc:8145 Review-Url: https://codereview.webrtc.org/3007193002 Cr-Commit-Position: refs/heads/master@{#19691}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give ability to measure decibels full scale and manual control about microphone recording to the app.