-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge wscat2 #30
base: master
Are you sure you want to change the base?
Merge wscat2 #30
Conversation
Better usage
Show code and reason for non-1000 close events from server
Used with --connect, reconnects on disconnection or error. After 4 retries the user is prompted for action before trying again. Useful when debugging a local server that's restarted during development since your command history is intact.
Added ParseCommands and KeepAlive options, plus frame counting and connection timers. ParseCommands option allows you to send ping, pong or message frames, display last message received, and the frame counters. Keep alive allows you to send a ping frame on a timer to keep your connection alive.
Looking at this... this is going to be tricky, and I think I'm going to need @jnordberg's help if we want to do this successfully. First of all, @jnordberg, are you interested in merging the projects? |
Sure! I can take a look at getting this merged when I have some time. |
Fix installation instructions
Hey everyone! I started sorting out this merge but realised pretty fast that I'd rather rewrite the entire project from scratch, so I did that instead :) I always wanted wscat to behave more like netcat allowing you to use it in test scripts etc. My rewrite removes a lot of functionality and probably this is not what everyone wants. To remedy this my suggestion is to create a separate project called Let me know what you think! |
New version is here https://github.com/jnordberg/wscat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long on the review...
Overall, I think the rewrite and splitting out wsterm
is a good thing. I also like that you broke things out into reasonable modules.
I think the following options need to be supported for approval:
-p, --protocol <version> optional protocol version
-o, --origin <origin> optional origin
--host <host> optional host
-s, --subprotocol <protocol> optional subprotocol
-n, --no-check Do not check for unauthorized certificates
-H, --header <header:value> Set an HTTP header. Repeat to set multiple. (--connect only)
--auth <username:password> Add basic HTTP authentication header. (--connect only)
--ca <ca> Specify a Certificate Authority (--connect only)
--cert <cert> Specify a Client SSL Certificate (--connect only)
--key <key> Specify a Client SSL Certificate's key (--connect only)
--passphrase [passphrase] Specify a Client SSL Certificate Key's passphrase (--connect only). If you don't provide a value, it will be prompted for.
I think we can collaborate on getting these in. shouldn't be too hard. What do you think?
|
||
WebSocket cat. | ||
wscat2 [![Build Status](https://travis-ci.org/jnordberg/wscat.svg?branch=master)](https://travis-ci.org/jnordberg/wscat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be wscat
, no?
README.md
Outdated
|
||
``` | ||
$ wscat -h | ||
usage: wscat [-h] [-v] [-l PORT] [-b] [-k] [-d] [address] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're missing client tls support here?
* WebSocket subprotocol * Subprotocol help * Sort subprotocol keys * ICLIOptions fix * Update Makefile * Update Makefile * Fix IOptions
And add a package-lock.json
No longer needed with updated typedefs
Dependency ws no longer supports node 6
Has there been any recent progress on this? The last update seems to be from 2 years ago but it is a feature which should not be missing in this toolkit |
No description provided.