Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix share dialog saving behavior #3269

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: Fix share dialog saving behavior #3269

merged 2 commits into from
May 1, 2024

Conversation

kof
Copy link
Member

@kof kof commented May 1, 2024

Description

  1. You couldn't type space at the end of the shared link name
  2. When clicking outside it would save the value

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof requested a review from istarkov May 1, 2024 00:51
@kof kof merged commit ec26bd7 into main May 1, 2024
29 checks passed
@kof kof deleted the fix-share-dialog branch May 1, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants