Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add backwards compatibility for children in code text #3270

Merged
merged 1 commit into from
May 1, 2024

Conversation

kof
Copy link
Member

@kof kof commented May 1, 2024

Description

Initially we allowed using any component inside code text and now we need to keep backwards compatibility because its not easy to migrate that to pure text.

Steps for reproduction

  1. would need to find any old instance with code text that has other instances inside
  2. see that it still works
  3. override it with new code property

Code Review

  • hi @istarkov , I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof requested a review from istarkov May 1, 2024 09:09
@kof kof merged commit 8b99866 into main May 1, 2024
29 checks passed
@kof kof deleted the fix-old-code-text branch May 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants