Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Add System Resource instead of $resources url #3341

Merged
merged 4 commits into from
May 11, 2024

Conversation

kof
Copy link
Member

@kof kof commented May 10, 2024

Description

ref #3308

image image

TODO:

  • - Remove copy for curl
image

Steps for reproduction

Add Variable, System Resource, open Select, check texts

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof requested a review from istarkov May 10, 2024 16:23
@istarkov istarkov merged commit 2496f68 into main May 11, 2024
51 of 56 checks passed
@istarkov istarkov deleted the xml-ui.staging branch May 11, 2024 14:55
@kof kof changed the title feat: Add System Resource instead of $resources url experimental: Add System Resource instead of $resources url May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants