Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix arrow focus #3474

Merged
merged 1 commit into from
Jun 2, 2024
Merged

fix: Fix arrow focus #3474

merged 1 commit into from
Jun 2, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 2, 2024 •
edited by TrySound
Loading

Ref #3343 #3080

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov requested a review from TrySound June 2, 2024 09:37
TrySound
TrySound approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Fixes both cases

@istarkov istarkov merged commit 48503c4 into main Jun 2, 2024
15 checks passed
@istarkov istarkov deleted the fix-down-btn branch June 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istarkov @TrySound