Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it easy for a self-hosted version to set the plan features #3475

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 2, 2024

Description

closes #3400

+ on dev login its now possible to add any email
like
{code}:[email protected] to login as other user

Steps for reproduction

Login on main with {code}:[email protected]

  • See no plan
image

Login on main as usual

  • See user has plan
image

Login locally
See user has plan

image

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov requested review from TrySound and kof June 2, 2024 11:37
@istarkov istarkov merged commit 3105b5c into main Jun 2, 2024
13 checks passed
@istarkov istarkov deleted the plan-feat branch June 2, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy for a self-hosted version to set the plan features
2 participants