Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use secure cookies in local development and fix layout nesting #3949

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

istarkov
Copy link
Member

Description

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested review from kof and TrySound August 16, 2024 15:55
@kof kof changed the title chore: Use secure cookie at local development, fix layout nesting chore: Use secure cookies in local development and fix layout nesting Aug 16, 2024
@istarkov istarkov merged commit 50575df into main Aug 16, 2024
16 checks passed
@istarkov istarkov deleted the fix-ssl-auth branch August 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants