Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Project login #3990

Merged
merged 3 commits into from
Aug 24, 2024
Merged

chore: Project login #3990

merged 3 commits into from
Aug 24, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Aug 22, 2024

Description

New Project login without any automation or link changes.

corresponding PR
https://github.com/webstudio-is/webstudio-saas/pull/319

Steps for reproduction

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov temporarily deployed to postgres_development August 22, 2024 05:39 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development August 22, 2024 08:06 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development August 22, 2024 14:51 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development August 22, 2024 15:02 — with GitHub Actions Inactive
Fix

Add endpoints

Login/Logout

Show headers

Try patch vercel/remix

Try patch build

Simplify

Remove patch

Remove patch

Fix

Fix origin

Switch on URL

Fix

Fix urls

Fix projectId

Fix logout

Add patch comment

Improve logs

Fixes

Fix Schema

Merge
@istarkov istarkov temporarily deployed to postgres_development August 24, 2024 05:54 — with GitHub Actions Inactive
@istarkov istarkov requested a review from kof August 24, 2024 05:58
@istarkov istarkov merged commit 0b0707e into main Aug 24, 2024
24 checks passed
@istarkov istarkov deleted the oauth.staging branch August 24, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants