Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove index hack, move canvas layout outside for readability #4006

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Aug 24, 2024

Description

iframe now points to /canvas route
$ (splat) route has no UI, and now does only technical part.
_index route will be builder route on builder urls i.e. {ProjectId}.apps.webstudio.is (next PR)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested review from kof and TrySound August 24, 2024 07:46
@istarkov istarkov closed this Aug 24, 2024
@istarkov istarkov reopened this Aug 24, 2024
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, will do some more testing later

@istarkov istarkov merged commit 45e748f into main Aug 24, 2024
16 checks passed
@istarkov istarkov deleted the remove.index branch August 24, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants