-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: New Builder Auth #4010
Merged
Merged
chore: New Builder Auth #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
981d263
to
f2a1a3b
Compare
Make builder the root path cleanups Add everything Remove tmp Remove Fix Fix layout Fix Fix url Add cross-origin check Fix stale data dashboardPath Fix canvas-url path Improve logout Add bloom filter Commit projects to the session Add leak Change templates Trigger Build rename throw to prevent any cross origin Add log Change session cookie Add comments cleanup + comments Fix Test delete deployments Test call Try delete all fix Trigger Build Fix Add cleanup after r2 potpone after test
TrySound
reviewed
Aug 28, 2024
TrySound
reviewed
Aug 28, 2024
TrySound
approved these changes
Aug 28, 2024
kof
pushed a commit
that referenced
this pull request
Aug 30, 2024
## Description ### Full track webstudio-is/webstudio-saas#317 (comment) So thoughts about session webstudio-is/webstudio-saas#317 (comment) Some explanations what is fixed and how webstudio-is/webstudio-saas#317 (comment) Next PR: - [x] - Old share links auto redirect - [x] - Try make better error message having that current PR will logout all users. ## Steps for reproduction 1. Login using `google login` or `dev login` try to open projects on dahsboard, create new, clone delete etc. 2. Try to open projects on dahboard, see each is on it's own domain and work 3. Try to open project link (without share token) with other user - should fail. 4. Try publish/clone any links and operations. 5. Share project from `userA`: - try to open it with other `userB` - see `userB` is not logged in to that project - try to get using fetch from console anything about `userB` or `userA` i.e rest etc endpoints on apps.webstudio.is domain - try to open incognito, check it works. 6. Open few project, then logout from dashboard, reload project page - See login page - Try to login as same uer - see it works - Or try to login as another user - see auth error ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Full track
https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2289241819
So thoughts about session
https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2314515772
Some explanations what is fixed and how
https://github.com/webstudio-is/webstudio-saas/issues/317#issue-2465048823
Next PR:
Steps for reproduction
google login
ordev login
try to open projects on dahsboard, create new, clone delete etc.userA
:userB
userB
is not logged in to that projectuserB
oruserA
i.e rest etc endpoints on apps.webstudio.is domainCode Review
Before requesting a review
Before merging
.env
file