Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Form filters reset scroll position #4267

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Form filters reset scroll position #4267

merged 2 commits into from
Oct 11, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Oct 11, 2024 •
edited
Loading

Description

closes #4229

Steps for reproduction

https://form-scroll-reset-iodju.wstd.work/?opt=c

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound October 11, 2024 11:52
@istarkov istarkov merged commit c1041f7 into main Oct 11, 2024
29 checks passed
@istarkov istarkov deleted the form-scroll.staging branch October 11, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form filters reset scroll position
2 participants
@istarkov @TrySound