feat: add resource control for webhook form action #4333
Conversation
Ref #4093 #3871 Here added new resource control for out properties. It is replaced action and method properties webhook form. Now users will be able to additionally provide headers. In another PR headers will let user to customize body format. Also migrated "action" in existing webhook forms to resource prop type.
|
|
Haven't tested, but looks great, lets list what this enables from use cases perspective, so that once @johnsicili is back we can record an edu video, maybe replacing the old form video. Are all of these done? #4093 |
|
So far I see 2 use cases we need to demonstrate:
Am I correct to assume both use cases are supported now? |
|
In this PR only headers are supported |
|
Got it, so this unlocks a use case like useplunk. |
|
Yes, though I'm planning a small launch with all those features requested so webhook forms would make more sense to users. |
|
Btw you should try to post something to https://docs.useplunk.com/api-reference/contacts/subscribe to see if we are still missing something there |
|
Hi, we are doing an ecommerce site (with a lot of handmade javascript) and we really need this feature, as I can see is already working and passes all the CI checks, I will mean a lot if we get those new configs for the headers. Right now we are going to pass (in some hidden fields) the values we need in the headers thru zapier and then move the hidden fields to the corresponding header just to make the site work, but it is a huge security issue. |
| }; | ||
|
|
||
| const areAllFormErrorsVisible = (form: null | HTMLFormElement) => { | ||
| if (form === null) { |
There was a problem hiding this comment.
Looks like huge error if form is not available at the moment
| if ( | ||
| element.validity.valid === false && | ||
| // rely on data-color=error convention in webstudio design system | ||
| element.getAttribute("data-color") !== "error" |
There was a problem hiding this comment.
It is though it works and I didn't figure out another way.
Ref #4093 #3871
Here added new resource control for out properties. It is replaced action and method properties webhook form. Now users will be able to additionally provide headers. In another PR headers will let user to customize body format.
Also migrated "action" in existing webhook forms to resource prop type.