Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow finding tokens #4625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow finding tokens #4625

wants to merge 2 commits into from

Conversation

TrySound
Copy link
Member

Ref #3901 #4608

Here added new command panel group: tokens. For now only support selecting which opens a list of instances the token is defined on.

Screen.Recording.2024-12-20.at.16.58.58.mov

Ref #3901 #4608

Here added new command panel group: tokens. For only only supported
selecting which opens a list of instances the token is defined on.
@TrySound TrySound requested review from kof, istarkov and johnsicili and removed request for istarkov December 20, 2024 10:01
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think it would be helpful to show the page in commands where we usually show the shortcuts.

Eg

Heading 1 About

Might help understand usage better at a glance.

@kof
Copy link
Member

kof commented Dec 22, 2024

Nice. I think it would be helpful to show the page in commands where we usually show the shortcuts.

Eg

Heading 1 About

Might help understand usage better at a glance.

I was also thinking of making a special shortcuts overview page, but I think this is a better idea:

  1. we need a help center anyways, so we are probably going to link the docs in the iframe for this
    2.shortcuts is already in the docs

If we do this, showing shortcuts help is basically opening help center with shortcuts page open, thoughts?

@johnsicili
Copy link
Contributor

Actually I meant have info in the panel about where those tokens are used:

Screenshot 2024-12-22 at 10 46 23 AM

So on the right side it would say the page that token is on

@kof
Copy link
Member

kof commented Dec 22, 2024

Actually I meant have info in the panel about where those tokens are used:

Those are instances. Bogdan is adding a category title "Instances", so that there is no confusion and also a button "back" to get back to the previous view

@kof
Copy link
Member

kof commented Dec 22, 2024

Showing which page the instance is on can be difficult, especially if its on many pages, but one can separately search the Instance name and see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants