fix: relax detaching constraint #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
approved these changes
Dec 29, 2024
johnsicili
requested changes
Dec 30, 2024
There was a problem hiding this comment.
1 Delete error
- Add nav menu
- Del menu content
- See error
del.mp4
2 Body
Also body in prod is "detachable" as it shows the dragging ability
3 No errors
When dragging internal items that can't leave the parent, we don't show a toast anymore. Not sure if this is intentional.
istarkov
approved these changes
Jan 4, 2025
|
Fixed 1 and 2. And yes we replaced "detachable" flag with constraints so instead of draggability we check if instance can be dropped considering all constraints. |
Every time somebody is facing invalid constraint issue whole tree is blocked from deleting instances except the problematic one with actual issue. Here rewrote detachability check to validate only ancestors and avoid traversing potentially problematic siblings.
johnsicili
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time somebody is facing invalid constraint issue whole tree is blocked from deleting instances except the problematic one with actual issue.
Here rewrote detachability check to validate only ancestors and avoid traversing potentially problematic siblings.