Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support content editable in FF and Safari #4683

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix: Support content editable in FF and Safari #4683

merged 1 commit into from
Dec 31, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 30, 2024 •
edited
Loading

Description

There is no blur event in FF and Safari when focused node is detached from the DOM

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound December 30, 2024 20:45
@istarkov istarkov merged commit cee3931 into main Dec 31, 2024
17 checks passed
@istarkov istarkov deleted the ff-safari branch December 31, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istarkov @TrySound