Now twilio is no longer being used, consider trying to go fully static? #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obviously I had to guess what |
|
Thanks for the PR. Agree that going static would simplify this. Will consider it when I have more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to understand this project I realised that the back-end actually doesn't do anything at all.
Making a change like this would vastly simplify the project as a whole, and (in my opinion) make it easier to re-host and contribute to. Potentially even committing
__rtcConfig__.jsonwould allow PRs to be hosted on github pages and the like.I'd understand if you wanted to keep the potential flexibility (especially if twilio don't provide any other method of getting ICE details), but thought I'd make this PR regardless.