-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go binding #1
Conversation
I haven't made any noteworthy contributions to the Go bindings.
What about using a script to pull the header files? - stupidly asked, as there might be a good reason you include them. |
The headers were copied in because there's no way to pull in external non-Go code such as C/C++ headers with a normal Go workflow. It's a fight against Go tooling that I don't believe we can win. We've been imposing manual steps or scripts onto Go users. It isn't a nice experience for users. I wrote a Go generator that pulls in headers but it requires users to also manually run the generator. I've tried vendoring but it requires us to sprinkle Go-related files in the repository of the core library which means it isn't much better than leaving the Go bindings there. Oh, and vendoring also requires users to opt into using vendoring (for all of their Go dependencies, not just webview). This PR accepts the downside of copying headers in order to put an end to the clumsy process we put users through. |
Yes security issues make it not justifiable to automatically run a generator. I think running |
Part of the work for splitting Go binding from core webview library.
See the following issue: