Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate wechaty-puppet-hostie proto buffer #23

Closed
wants to merge 12 commits into from
Closed

Conversation

dchaofei
Copy link
Collaborator

No description provided.

@dchaofei dchaofei requested review from dingdayu and SilkageNet April 13, 2020 04:54
@dchaofei dchaofei changed the title gen wechaty-puppet-hostie proto buffer generate wechaty-puppet-hostie proto buffer Apr 13, 2020
@huan
Copy link
Member

huan commented Apr 13, 2020

Hi @dchaofei , your PR looks great!

As we discussed before, I'd like to put the generated Go stub source code into chatie/grpc repo so that we can manage all the Proto Buffer files and the generated Go source codes at the same place, which will make our DevOps process more efficiently. (Also we should garantee there's only one version proto buffer config file at one place)

I have created an issue about this topic at wechaty/grpc#50, please feel free to let me know what you think.

After we are all feel comfortable with the design, then I'd like to suggest that you create a new pull request to chatie/grpc and let's move this PR over there.

@dchaofei
Copy link
Collaborator Author

wechaty/grpc#50

@dchaofei dchaofei closed this Apr 13, 2020
@dchaofei dchaofei deleted the gen-proto-buffer branch April 14, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants