[김민재] Assignment 2: Express API - 유저 회원가입 하기(암호화) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyeongraekim
requested changes
Aug 10, 2023
minjae/app.js
Outdated
Comment on lines
14
to
27
| /* | ||
| const makeHash = async (password, saltRounds) => { | ||
| return await bcrypt.hash(password, saltRounds); | ||
| }; | ||
|
|
||
|
|
||
| const getEncryptedPassword = async () => { | ||
| const hashedPassword = await makeHash(password, saltRounds); | ||
| console.log("다음은 암호화된 비밀번호 입니다: ", hashedPassword); | ||
| }; | ||
|
|
||
|
|
||
| getEncryptedPassword(); | ||
| */ |
There was a problem hiding this comment.
- 불필요한 코드 주석을 삭제하여 주세요!~
minjae/app.js
Outdated
|
|
||
| await mySqlDataSource.query( | ||
| "INSERT INTO westagram.users (user_id, password, name, phone, email, guest_yn) VALUES (?, ?, ?, ?, ?, ?);", | ||
| [id, pwd, name, phone, email, guest_yn] | ||
| [id, cryptedpassword, name, phone, email, guest_yn] |
There was a problem hiding this comment.
- 해당 id 값은 회원 가입시, 클라이언트에게 전달되지 않는 것이 아니라, AUTO_INCREMENT에 의해 자동으로 고유값을 설정하는 데이터베이스의 성질을 이용해주시면 좋을 것 같네요!
There was a problem hiding this comment.
해당 변수명을 컬럼명과 동일하게 user_id로 변경했습니다.
added 2 commits
August 10, 2023 14:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 - 해당 브랜치(PR)에서 구현하고자 하는 하나의 목표 작성
:: 구현 사항 설명 - 해당 브랜치(PR)에서 작업한 내용 작성
:: 테스트 결과 이미지
:: 기타 질문 및 특이 사항