Bump symfony/dotenv #137
Merged
Bump symfony/dotenv #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At first, I just wanted to bump symfony/dotenv to 7 for users that are on PHP 8.2.
However, some dev dependencies got symfony/dotenv stuck at 6.4.4.
So I bumped them too (vimeo/psalm & symfony/process) to allow symfony/dotenv 7 upgrade.
How has this been tested?
Using your QA workflow here:
https://github.com/nlemoine/wpstarter/actions/runs/8214878478
All unit tests pass.
Types of changes
No noticeable change on the code perspective. But bumping Pslam to the lastest version triggered many errors, which in the end might not be a bad thing. I guess the tool improved over time and spotted more potential errors.
Checklist: