Revert "Merge pull request #77 from wednesday-solutions/feature/roots… #83

himanshu-wedensday · 2024-04-15T14:03:09Z

…creen-refactor"

This reverts commit 9f18cdc, reversing changes made to 230157c.

Ticket Link

Description

Steps to Reproduce / Test

GIF's

Summary by CodeRabbit

Refactor
- Refactored the RootScreen component for improved lifecycle management.
Tests
- Updated RootScreen test configurations and streamlined state setup in reducer tests.

…creen-refactor" This reverts commit 9f18cdc, reversing changes made to 230157c.

coderabbitai · 2024-04-15T14:03:17Z

Walkthrough

The recent update involved refactoring the RootScreen component from a functional to a class-based structure in React, enhancing lifecycle management. Additionally, test setups and methodologies were streamlined across various test files, improving consistency and reducing redundancy in state initialization.

Changes

Files	Change Summary
`.../RootScreen/index.js`, `.../saga.js`	Refactored `RootScreen` to a class component; replaced `useEffect` with `componentDidMount`; modified navigator reference setting.
`.../RootScreen/tests/index.test.js`	Renamed `RootScreenTest` to `RootScreen`; added `submitSpy` in `beforeAll`.
`.../RootScreen/tests/reducer.test.js`	Replaced `setupTests` with `beforeEach` for state initialization; updated test cases.

🐰✨
In the realm of code, where logic meets charm,
A class arose, with methods to disarm.
Tests align, as states refine,
Oh, how neatly the lines intertwine!
Cheers to changes, as progress marches on! 🎉
🐰✨

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f18cdc and 8ad104d.

Files selected for processing (4)

app/scenes/RootScreen/index.js (2 hunks)
app/scenes/RootScreen/saga.js (1 hunks)
app/scenes/RootScreen/tests/index.test.js (1 hunks)
app/scenes/RootScreen/tests/reducer.test.js (1 hunks)

Additional Context Used

GitHub Check Runs (1)

Coverage annotations (🧪 jest-coverage-report-action) success (27)

app/scenes/RootScreen/index.js: [warning] 26-28: 🧾 Statement is not covered
Warning! Not covered statement

app/scenes/RootScreen/index.js: [warning] 27-27: 🧾 Statement is not covered
Warning! Not covered statement

app/scenes/RootScreen/index.js: [warning] 26-26: 🕹 Function is not covered
Warning! Not covered function

app/scenes/RootScreen/index.js: [warning] 27-27: 🕹 Function is not covered
Warning! Not covered function

Additional comments not posted (7)

app/scenes/RootScreen/saga.js (1)

Line range hint 13-13: This watcher saga setup is correctly implemented.

app/scenes/RootScreen/tests/reducer.test.js (1)

9-12: The use of beforeEach for state initialization improves test isolation and readability.

app/scenes/RootScreen/tests/index.test.js (2)

9-9: Correcting the component import name enhances clarity and maintainability.

14-16: Centralizing the submitSpy setup in beforeAll reduces redundancy and improves test manageability.

app/scenes/RootScreen/index.js (3)

11-14: The use of componentDidMount to trigger the startup action is appropriately implemented.

16-18: Encapsulating navigator reference setting in a method is a good practice for class components.

20-26: The rendering logic using Container to wrap AppNavigator is correctly implemented.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-04-15T14:06:16Z

Coverage report

Total coverage

Status	Category	Percentage	Covered / Total
🟢	Statements	93.17%	191/205
🟡	Branches	87.8%	36/41
🟡	Functions	89.74%	70/78
🟢	Lines	94.88%	389/410

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 8ad104d

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-15T14:08:15Z

app/scenes/RootScreen/saga.js

 import { rootScreenTypes } from './reducer';

 /**
 * The startup saga is the place to define behavior to execute when the application starts.
 */
 export function* startup() {
-  setTimeout(() => navigateAndReset('MainScreen'), 1000);
+  setTimeout(() => NavigationService.navigateAndReset('MainScreen'), 1000);


Consider using delay from redux-saga instead of setTimeout for better control and testability.

- setTimeout(() => NavigationService.navigateAndReset('MainScreen'), 1000); + yield delay(1000); + NavigationService.navigateAndReset('MainScreen');

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

setTimeout(() => NavigationService.navigateAndReset('MainScreen'), 1000);

yield delay(1000);

NavigationService.navigateAndReset('MainScreen');

Revert "Merge pull request #77 from wednesday-solutions/feature/roots…

8ad104d

…creen-refactor" This reverts commit 9f18cdc, reversing changes made to 230157c.

coderabbitai bot reviewed Apr 15, 2024

View reviewed changes

himanshu-wedensday closed this Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Merge pull request #77 from wednesday-solutions/feature/roots… #83

Revert "Merge pull request #77 from wednesday-solutions/feature/roots… #83

himanshu-wedensday commented Apr 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Apr 15, 2024

coderabbitai bot left a comment

coderabbitai bot Apr 15, 2024

	setTimeout(() => NavigationService.navigateAndReset('MainScreen'), 1000);
	yield delay(1000);
	NavigationService.navigateAndReset('MainScreen');

Revert "Merge pull request #77 from wednesday-solutions/feature/roots… #83

Revert "Merge pull request #77 from wednesday-solutions/feature/roots… #83

Conversation

himanshu-wedensday commented Apr 15, 2024 • edited by coderabbitai bot Loading

Ticket Link

Related Links

Description

Steps to Reproduce / Test

GIF's

Summary by CodeRabbit

coderabbitai bot commented Apr 15, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Apr 15, 2024

Coverage report

Total coverage

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 15, 2024

Choose a reason for hiding this comment

himanshu-wedensday commented Apr 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)