Skip to content

Commit

Permalink
Merge pull request #113 from wednesday-solutions/fix/cdk-db-versions
Browse files Browse the repository at this point in the history
fix/cdk-db-version: upgraded the db engine version of postgres and mysql
  • Loading branch information
praveenkumar1798 authored Feb 23, 2024
2 parents 5b4eac2 + 1f07679 commit 5233726
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: "1.20"
go-version: "1.21"
cache: false

- name: Install pre-commit dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/product-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: 1.20
go-version: 1.21

- name: Actions Ecosystem Action Get Merged Pull Request
uses: actions-ecosystem/[email protected]
Expand Down
29 changes: 18 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,18 @@ It contains a number of <a href="https://github.com/wednesday-solutions">Wednesd

## Table of contents

1. [Overview](#overview)
2. [Tech Stacks](#tech-stacks)
3. [Pre-requisites](#pre-requisites)
4. [Installation](#installation)
5. [Creating a Project](#creating-a-project)
6. [User Guide](#user-guide)
7. [Project Structure](#project-structure)
8. [Feedback](#feedback)
9. [License](#license)
10. [Future Plans](#future-plans)
- [Table of contents](#table-of-contents)
- [Overview](#overview)
- [Tech Stacks](#tech-stacks)
- [Setup and Configuration.](#setup-and-configuration)
- [Pre-requisites](#pre-requisites)
- [Installation](#installation)
- [Creating a Project](#creating-a-project)
- [User Guide](#user-guide)
- [Project Structure](#project-structure)
- [Feedback](#feedback)
- [License](#license)
- [Future Plans](#future-plans)

## Overview

Expand All @@ -72,7 +74,7 @@ This tool will have support for production applications using the following tech

**Web:**

- [React JS](https://gitub.com/wednesday-solutions/react-template)
- [React JS](https://github.com/wednesday-solutions/react-template)
- [Next JS](https://github.com/wednesday-solutions/nextjs-template)

**Backend:**
Expand Down Expand Up @@ -109,6 +111,11 @@ AWS Secret Access Key: MYSECRETKEY
Default region name [us-west-2]: MYAWSREGION
Default output format [None]:
```
- Create a repository in your [AWS ECR](https://aws.amazon.com/ecr/).

```bash
$ aws ecr create-repository --repository-name cdk-hnb659fds-container-assets-MYAWSACCOUNTID-MYAWSREGION
```


### Installation
Expand Down
6 changes: 3 additions & 3 deletions internal/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ func ReadJsonDataInSstOutputs() map[string]interface{} {
func GetOutputsBackendObject(environment, stackDir string) TaskDefinitionDetails {
camelCaseDir := strcase.ToCamel(stackDir)
jsonData := ReadJsonDataInSstOutputs()
if jsonData == nil {
errorhandler.CheckNilErr(fmt.Errorf("outputs.json is not valid."))
}
// if jsonData == nil {
// errorhandler.CheckNilErr(fmt.Errorf("outputs.json is not valid."))
// }
var td TaskDefinitionDetails
td.Environment = environment
td.EnvName = GetShortEnvName(environment)
Expand Down
4 changes: 2 additions & 2 deletions pickyhelpers/sources/create_infra_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,13 @@ func BackendStackSource(database, dirName, environment string) string {
if database == constants.PostgreSQL {
dbEngineVersion = "PostgresEngineVersion"
dbPortNumber = utils.FetchExistingPortNumber(dirName, constants.PostgresPort)
dbEngine = "DatabaseInstanceEngine.postgres({\n\t\t\t\tversion: PostgresEngineVersion.VER_14_2,\n\t\t\t})"
dbEngine = "DatabaseInstanceEngine.postgres({\n\t\t\t\tversion: PostgresEngineVersion.VER_14_8,\n\t\t\t})"
dbUri = "`postgres://${username}:${password}@${database.dbInstanceEndpointAddress}/${dbName}`"
dbHost = "POSTGRES_HOST: database.dbInstanceEndpointAddress"
} else if database == constants.MySQL {
dbEngineVersion = "MysqlEngineVersion"
dbPortNumber = utils.FetchExistingPortNumber(dirName, constants.MysqlPort)
dbEngine = "DatabaseInstanceEngine.mysql({\n\t\t\t\tversion: MysqlEngineVersion.VER_8_0_31,\n\t\t\t})"
dbEngine = "DatabaseInstanceEngine.mysql({\n\t\t\t\tversion: MysqlEngineVersion.VER_8_0_34,\n\t\t\t})"
dbUri = "`mysql://${username}:${password}@${database.dbInstanceEndpointAddress}/${dbName}`"
dbHost = "MYSQL_HOST: database.dbInstanceEndpointAddress"
}
Expand Down

0 comments on commit 5233726

Please sign in to comment.