We Got Coders entrance test for Paul O'Hara #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgarland
reviewed
Jun 28, 2017
primes.rb
Outdated
|
|
||
| #Code below was an attempt over 1.5 hours, on 19/07/2017, to implement an algorithm to add up prime numbers, but in hind sight I should | ||
| #have used an array to hold dividing values up to num being checked - within the inner loop - to get the code to work correctly. |
There was a problem hiding this comment.
Good stuff- keep going! If you commit further changes and git push them they'll show up here- no need to open another PR. If you decide to finish it we'd gladly look over it
…Hara 01/07/2017, 3rd attempt to get ruby code to identify and add up prime numbers to a specified limit
|
3rd attempt to get ruby code working to identify and add up prime numbers to a set limit. Code submitted 01/07/2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find pull request for the We Got Coders Code Challenge completed late 17/06/2017 through to 19/06/2017 by Paul O'Hara, committed to local master/github upload 19/06/17, pull request to wegotcoders/wgc_groundwork submitted on 20/06/2017.