fix: improve k3s upgrade, more cli opts, updates k3s env #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to update k3s flags
bohdand-weka
commented
Feb 1, 2024
| @@ -29,6 +29,11 @@ type Flags struct { | |||
| RemoteVersion string | |||
| } | |||
|
|
|||
| Iface string | |||
There was a problem hiding this comment.
those flags moved to common
bohdand-weka
commented
Feb 1, 2024
| @@ -55,7 +55,7 @@ func runSetup(cmd *cobra.Command, args []string) (err error) { | |||
| } | |||
| }() | |||
|
|
|||
| err = k3s.Install(cmd.Context(), k3s.InstallConfig{ | |||
| err = k3s.Install(cmd.Context(), k3s.Config{ | |||
There was a problem hiding this comment.
now install config and upgrade config are the same
bohdand-weka
commented
Feb 1, 2024
| logger.Info().Msg("Install completed") | ||
|
|
||
| return nil | ||
| return k3sInstall(ctx, c, fi, r) |
There was a problem hiding this comment.
moved to shared func
bohdand-weka
commented
Feb 1, 2024
| "github.com/weka/gohomecli/internal/utils" | ||
| ) | ||
|
|
||
| const ( | ||
| k3sInstallPath = "/usr/local/bin" | ||
| ) | ||
|
|
||
| type Config struct { |
There was a problem hiding this comment.
moved to k3s file from install
bohdand-weka
commented
Feb 1, 2024
| @@ -20,7 +20,7 @@ func upgrade(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| err := k3s.Upgrade(r.Context(), k3s.UpgradeConfig{}) | |||
| err := k3s.Upgrade(r.Context(), k3s.Config{}) | |||
There was a problem hiding this comment.
web is still not implemented
gonenidan
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.