improvements to the method invokers implementation #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The improvements here should be non-controversial. With these improvements, Weld passes most of the proposed TCK for method invokers (jakartaee/cdi-tck#502), with the exception of cca 4 tests where the specification needs more discussion. |
Ladicek
force-pushed
the
method-invokers
branch
from
b33fd73
to
69d5f92
Compare
Includes one tiny improvement to the Language Model implementation that should be clarified in the next version of the specification.
Ladicek
force-pushed
the
method-invokers
branch
from
69d5f92
to
43f3077
Compare
manovotn
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes one tiny improvement to the Language Model implementation that should be clarified in the next version of the specification.