Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-2774 Implement BM methods for event/bean assignability #2906

Closed
wants to merge 1 commit into from

Conversation

manovotn
Copy link
Contributor

The PR is going to fail CI until we get a CDI API release and ideally a TCK release to have tests.

There are no Weld specific tests for this as Weld doesn't add anything beyond what's in the TCK coverage via jakartaee/cdi-tck#526

@manovotn
Copy link
Contributor Author

I've added some validations:

  • Qualifier validation for all inputs (if the annotation is a CDI qualifier)
  • Event type validation for unresolved type variable
  • Filtering of provided bean types for legal bean types only

These are so far not covered by the linked TCK test.
If they won't be covered, I'll add Weld test cases.

@manovotn manovotn force-pushed the weld2774 branch 2 times, most recently from 317766d to 37c418a Compare January 23, 2024 17:11
@manovotn
Copy link
Contributor Author

Superseeded by #2911

@manovotn manovotn closed this Feb 24, 2024
@manovotn manovotn deleted the weld2774 branch February 24, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants