Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lorax conversion to use libdnf5 #1319

Closed
wants to merge 0 commits into from
Closed

lorax conversion to use libdnf5 #1319

wants to merge 0 commits into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Apr 6, 2023

No description provided.

@bcl bcl force-pushed the master-dnf5-2 branch 2 times, most recently from 94e8632 to 684ceac Compare April 6, 2023 21:23
@coveralls
Copy link

coveralls commented Apr 6, 2023

Pull Request Test Coverage Report for Build 5557939126

  • 94 of 237 (39.66%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.1%) to 43.457%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pylorax/creator.py 2 3 66.67%
src/pylorax/treebuilder.py 13 17 76.47%
src/pylorax/init.py 7 16 43.75%
src/pylorax/dnfbase.py 26 54 48.15%
src/pylorax/dnfhelper.py 14 42 33.33%
src/pylorax/ltmpl.py 32 105 30.48%
Files with Coverage Reduction New Missed Lines %
src/pylorax/creator.py 1 38.97%
src/pylorax/dnfbase.py 1 57.95%
src/pylorax/ltmpl.py 1 56.08%
src/pylorax/treebuilder.py 1 40.45%
src/pylorax/dnfhelper.py 3 33.8%
Totals Coverage Status
Change from base Build 5557115468: 0.1%
Covered Lines: 1611
Relevant Lines: 3496

💛 - Coveralls

@bcl bcl marked this pull request as ready for review June 23, 2023 18:42
@bcl bcl force-pushed the master-dnf5-2 branch 2 times, most recently from 2f7ce23 to f3b44d4 Compare December 8, 2023 16:46
@bcl
Copy link
Contributor Author

bcl commented Dec 8, 2023

Something is broken in the current rawhide container, switching it to Fedora 39 passes -- but I'm leaving it as rawhide so that it doesn't get left on 39 by accident :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants