Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-install: exclude renamed iwl firmware packages #1332

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented Jul 4, 2023

@pbrobinson renamed the Intel wireless firmware packages in the 20230625 build of linux-firmware. This causes installer image builds to fail because they want to pull in the old packages from the release repo because they fall in the "*-firmware" glob, but those packages are now obsoleted by the newer ones from updates/updates-testing, and dnf doesn't like that. This should resolve the problem by specifically excluding all the renamed packages from the glob. Of course, this change must go along with the newer linux-firmware package, or else you'll get an image that's missing a lot of wireless firmware.

@pbrobinson renamed the Intel wireless firmware packages in
the 20230625 build of linux-firmware. This causes installer
image builds to fail because they want to pull in the old packages
from the release repo because they fall in the "*-firmware" glob,
but those packages are now obsoleted by the newer ones from
updates/updates-testing, and dnf doesn't like that. This should
resolve the problem by specifically excluding all the renamed
packages from the glob. Of course, this change must go along
with the newer linux-firmware package, or else you'll get an
image that's missing a lot of wireless firmware.

Signed-off-by: Adam Williamson <[email protected]>
@AdamWill
Copy link
Contributor Author

AdamWill commented Jul 4, 2023

Note, we need this on F37 and F38 branches too. I am doing backport builds with the patch downstream to edit into the linux-firmware updates.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5457877475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.495%

Totals Coverage Status
Change from base Build 5426989872: 0.0%
Covered Lines: 1701
Relevant Lines: 3429

💛 - Coveralls

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@bcl bcl merged commit c7c6dc7 into weldr:master Jul 10, 2023
@bcl
Copy link
Contributor

bcl commented Jul 10, 2023

Also cherry picked to f38-branch and f37-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants