Wrap the dnf transaction in ProcMount to keep systemd happy #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we need to just mount /proc and /dev so this moves the mount and cleanup code for that into ProcMount, leaving the dracut specific code in DracutChroot (which uses ProcMount).
Some packages expect a filesystem that looks more like a real system. So this mounts /proc and /dev inside the dnf installroot while packages are being installed. This was prompted by a systemd change which has been fixed (systemd/systemd#28388) but as noted, it may happen again. Also update tests to adjust for this. Sadly the run_pkg_transaction test can now only be run as root. And when it doesn't run there is no /etc in the installroot so make the directory just to be sure it is present.
Macintosh HFS changed to Apple HFS. Accept either one.
--releasever=/ isn't setting $releasever when using dnf5.
The new pylint/astroid on rawhide doesn't know how to deal with datetime. Ignore the false positive error until it is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.