Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-install: only pull in qcom-firmware on aarch64 #1338

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

AdamWill
Copy link
Contributor

See https://bugzilla.redhat.com/show_bug.cgi?id=2178852 . This should save a chunk of space on the installer images for x86_64.

@AdamWill
Copy link
Contributor Author

@nullr0ute

@coveralls
Copy link

coveralls commented Aug 11, 2023

Pull Request Test Coverage Report for Build 5835035343

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.325%

Totals Coverage Status
Change from base Build 5812386118: 0.0%
Covered Lines: 1578
Relevant Lines: 3435

💛 - Coveralls

Copy link
Contributor

@nullr0ute nullr0ute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See https://bugzilla.redhat.com/show_bug.cgi?id=2178852 . This
should save a chunk of space on the installer images for x86_64.

Signed-off-by: Adam Williamson <[email protected]>
@AdamWill
Copy link
Contributor Author

changed "later" to "lower down" to be less ambiguous, and added the missing line to actually install qcom-firmware on aarch64 :)

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment correction

@bcl bcl merged commit b81280b into weldr:master Aug 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants