Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-cleanup.tmpl: fix typo 'gschadow' #1342

Merged
merged 1 commit into from
Sep 5, 2023
Merged

runtime-cleanup.tmpl: fix typo 'gschadow' #1342

merged 1 commit into from
Sep 5, 2023

Conversation

cjriches
Copy link
Contributor

@cjriches cjriches commented Sep 4, 2023

Commit fa2158c ("Drop non-determinism from default templates") made an attempt to ensure /etc/gshadow is reproducible by sorting it. However, there was a typo causing the sorted version to be saved as /etc/gschadow, leaving the original intact.

Fix the typo to ensure the file is overwritten.

Commit fa2158c ("Drop non-determinism from default templates") made
an attempt to ensure /etc/gshadow is reproducible by sorting it.
However, there was a typo causing the sorted version to be saved as
/etc/gschadow, leaving the original intact.

Fix the typo to ensure the file is overwritten.

Signed-off-by: Chris Riches <[email protected]>
@cjriches
Copy link
Contributor Author

cjriches commented Sep 4, 2023

I also noticed /etc/passwd- and /etc/shadow- files present with a few differences (the suffiexed version was missing rpcuser and install and had root login disabled). I couldn't find what code was creating these, and I'm not sure if they're an issue or not. Certainly a separate one if they are.

Seems those ones are just backups created by other tools. They might(?) be a reproducibility issue, but probably not if nobody's complained about it so far.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@bcl bcl merged commit 33f1877 into weldr:master Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants