Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly pull in more filesystem packages #1344

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented Sep 7, 2023

Turns out we've been relying on udisks2 dependencies to pull in several filesystem tools packages that anaconda actually needs to create and read supported filesystems. udisks2 just changed all those dependencies to Recommends, which don't get pulled into the installer environment. So we need lorax to specifically list all of these. e2fsprogs was already being pulled in through some other dep chain, but let's explicitly list it just to make sure we don't hit the same problem in future. From a look through the blivet code, I don't think pulling in udftools, exfatprogs or nilfs-utils will be useful, but we can check that with @vojtechtrefny .

Turns out we've been relying on udisks2 dependencies to pull in
several filesystem tools packages that anaconda actually needs
to create and read supported filesystems. udisks2 just changed
all those dependencies to Recommends, which don't get pulled
into the installer environment. So we need lorax to specifically
list all of these. e2fsprogs was already being pulled in through
some other dep chain, but let's explicitly list it just to make
sure we don't hit the same problem in future. From a look through
the blivet code, I don't think pulling in udftools, exfatprogs
or nilfs-utils will be useful, but we can check that with
@vojtechtrefny .

Signed-off-by: Adam Williamson <[email protected]>
@AdamWill
Copy link
Contributor Author

AdamWill commented Sep 7, 2023

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bcl bcl merged commit d0ce833 into weldr:master Sep 7, 2023
2 checks passed
@vojtechtrefny
Copy link
Contributor

I don't think pulling in udftools, exfatprogs or nilfs-utils will be useful, but we can check that with @vojtechtrefny .

We don't support NILFS at all in blivet and we don't support creating or resizing ExFAT or UDF so we don't need the tools for those either.

I am only wondering whether the anaconda-install-env-deps package would be a better place for this dependency. It already depends on hfsplus-tools.

@AdamWill
Copy link
Contributor Author

AdamWill commented Sep 8, 2023

It probably would, yeah, but this is where most of the stuff is and I wanted it fixed pronto. In general we might want to move quite a few things from lorax's templates to there.

@bcl
Copy link
Contributor

bcl commented Sep 8, 2023

I am only wondering whether the anaconda-install-env-deps package would be a better place for this dependency. It already depends on hfsplus-tools.

That's the right way to do this. At some point I'll try to do a pass through the templates and come up with a PR.

@VladimirSlavik
Copy link
Contributor

Agreed with all of the above - better put it here now, then move it all, eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants