Add example of using livemedia-creator inside GitHub Actions #1374
Commits on Feb 18, 2024
-
Do not install polkit-gnome for blivet-gui
blivet-gui-runtime doesn't depend on PolicyKit-authentication-agent only blivet-gui which is not on the installation images depends on polkit. Remove some unneccessary storage packages from runtime-install Anaconda already depends on following packages: - filesystem tools: btrfs-progs, ntfs-3g, ntfsprogs, jfsutils, f2fs-tools, xfsprogs, dosfstools, e2fsprogs - libblockdev-lvm-dbus - udisks2-iscsi hostname is no longer needed by dracut for iSCSI, see dracutdevs/dracut@ebe1821 Automatic commit of package [lorax] release [40.0-1]. Created by command: /usr/bin/tito tag --keep-version Adjust runtime-postinstall.tmpl for systemd config files move Systemd config files were moved from /etc to /usr/lib/systemd, so this snippet fails. Instead of editing the config file, just create a drop-in snippet with the desired configuration. Add python3-libdnf5 to the list of test packages This allows 'make test-in-podman' to work. libdnf5: Switch lorax to use libdnf5 At some point libdnf5 will be replacing libdnf. It is written in C++ with a SWIG interface, so accessing the API is quite different than before. This changes the template parser to use libdnf5 to install packages and remove files. Tests pass, and building the boot.iso is working. This simplifies the download callback a bit, we no longer have any idea what the total download size is, so just print the package count and any errors. The transaction callback logs install and script events. Fix writing out debug info for package files and sizes spec: Switch to using python3-libdnf5 Updates for latest libdnf5 changes test-packages: Make sure python3-libdnf5 is installed ltmpl: Add transaction error handling dnfbase: Fix url substitution support This fixes support for using $releasever (set by lorax --version) and $basearch (set from the host machine type or from lorax --buildarch) in the repo urls. test: Add pigz to test-packages ltmpl: Filter out other arches, clean up naming Because of the way the template filter is implemented it was picking up i686 packages along with the x86_64 ones. This adds an arch filter that only includes the basearch packages and 'noarch'. Also clean up the naming in install_pkg Automatic commit of package [lorax] release [40.1-1]. Created by command: /usr/bin/tito tag test-in-podman: Fix problem running in github actions Something is different when running rawhide (Fedora 40) using podman on GitHub. rsync has started returning errors about setting permissions. Work around this by passing `--no-perms` to rsync, it still works fine locally and clears up whatever the issue is with the action. ltmpl: Remove duplicate package objects from dnf5 results In dnf5 if you have multiple repositories with overlapping content, and the repo priorities are the same (eg. the default of 99) it will return multiple results with the same nevra. The transaction will fail when trying to install the duplicate rpms. This de-duplicates the results from `_pkgver`, assuming that packages with the same nevra and repo priority are interchangeable. Note that this only works at an individual `installpkg` level, not across the whole transaction. So it is possible for separate `installpkg` commands that select the same package to cause a crash -- currently this is not an issue, but is something to fix in the future. Includes a duplicate package in the ltmpl test to make sure this stays fixed. Fixes #1356 Automatic commit of package [lorax] release [40.2-1]. Created by command: /usr/bin/tito tag ltmpl: Check for errors after running the transaction Thanks to the discussion in rpm-software-management/dnf5#1074 lorax will now correctly log installation size errors like: The transaction process has ended abruptly: installing package llvm-libs-17.0.6-2.fc40.x86_64 needs 107MB more space on the / filesystem installing package libXv-1.0.12-1.fc40.x86_64 needs 107MB more space on the / filesystem installing package libXcomposite-0.4.6-1.fc40.x86_64 needs 107MB more space on the / filesystem runtime-install: Work around problem with conflicting packages See: rpm-software-management/dnf5#1111 dnf5 is returning anaconda-install-img-deps for 2 arches even though the noarch version number is lower than the x86_64 package. Work around this by selecting version 40.15 or later. Automatic commit of package [lorax] release [40.3-1]. Created by command: /usr/bin/tito tag init commit: Adding example action that uses livemedia-creator Adding dracut-live to the ks, so livemedia-creator can run Is the error because it can't remove dracut-live maybe? Switched references from fedora 39, to fedora minimized revert back, couldn't get it to work with livemedia-creator init commit: Adding example ks to run with github actions Pointing the action to the new ks file instead Changing boot location back to none, seeing if that's where the error is coming from Testing if it's because of a package missing from the minimal environment ltmpl: Pass packages to add_rpm_install as strings According to the discussion in: rpm-software-management/dnf5#1090 (comment) dnf5 handles NEVRA strings and package objects differently. So instead of passing in objects pass in the full NEVRA string. If a single install command has duplicates this won't matter, I already remove the dupes. But it should prevent problems where separate install commands end up selecting duplicate packages. runtime-cleanup: anaconda's new interface needs stdbuf Depends indirectly on stdbuf because cockpit-storage is using it. runtime-install: wget2-wget has replaced wget wget has been retired: https://src.fedoraproject.org/rpms/wget/c/ce69c17 in favor of wget2-wget: https://fedoraproject.org/wiki/Changes/Wget2asWget Signed-off-by: Adam Williamson <[email protected]> runtime-install: drop retired pcmciautils pcmciautils was just retired in Rawhide: https://src.fedoraproject.org/rpms/pcmciautils/c/24639b0 Signed-off-by: Adam Williamson <[email protected]> aarch64: Escape volid before using it s390: Escape volid before using it ltmpl: Handle installing provides with resolve_pkg_spec Previously the installpkg command used filter_match to select packages, which works great most of the time. It fails when the package is only available as a provide. This happened recently with wget moving to wget2-wget, causing builds to fail because it couldn't find wget. This changes installpkg to use the resolve_pkg_spec function, which as it happens also support globs and version comparison operators. DNF doesn't like the `==` operator, but I have retained support for it by translating it to a single `=`. I have dropped support for `=>` and `=<` since they are never used and are and odd way to specify `>=` and `>=` which of course still work. runtime-install: drop kdump-anaconda-addon I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <[email protected]> Adding anaconda-tools to the install list, maybe that's why moddep.lst doesn't exist Upgraded upload-artifact action because of deprecation notice on older version Added 'firstboot' flag to get user to go through the install screen Switched log from virt-install.log to program.log, since we're running in --no-virt mode now adding extra debug lines to try to get firstboot working docs mentioned initial-setup-gui, trying that out too mkksiso: Add support for adding an anaconda updates.img Anaconda supports an updates.img file that can be used to assist in development, the files in it are added to the boot.iso's rootfs before Anaconda is started. Use `mkksiso --updates /path/to/updates.img` to add the image to the iso. It can be used by itself or in combination with other options. It would be great way to avoid requirement for HTTP server for local development. Automatic commit of package [lorax] release [40.4-1]. Created by command: /usr/bin/tito tag Cleaned up list, grouping similar items. Added example for trying to get firstboot working Added basic comment at top, added override flag for uplaoding artifact, and testing out different KS file fedora-livemedia.ks worked, no need for a extra ks file Adding fedora_release to be an input, so that host always matches the OS it's trying to build Missed that the ks file was used in two places, so made it a variable so that can't happen again. Also adds flexability to try livemedia-creator against different ks in the repo forgot to specify type: string, though I think this is the default anyways Added input variable to filename of iso Adding dracut-live to the ks, so livemedia-creator can run Is the error because it can't remove dracut-live maybe? revert back, couldn't get it to work with livemedia-creator init commit: Adding example ks to run with github actions Changing boot location back to none, seeing if that's where the error is coming from Testing if it's because of a package missing from the minimal environment ltmpl: Pass packages to add_rpm_install as strings According to the discussion in: rpm-software-management/dnf5#1090 (comment) dnf5 handles NEVRA strings and package objects differently. So instead of passing in objects pass in the full NEVRA string. If a single install command has duplicates this won't matter, I already remove the dupes. But it should prevent problems where separate install commands end up selecting duplicate packages. runtime-cleanup: anaconda's new interface needs stdbuf Depends indirectly on stdbuf because cockpit-storage is using it. runtime-install: wget2-wget has replaced wget wget has been retired: https://src.fedoraproject.org/rpms/wget/c/ce69c17 in favor of wget2-wget: https://fedoraproject.org/wiki/Changes/Wget2asWget Signed-off-by: Adam Williamson <[email protected]> runtime-install: drop retired pcmciautils pcmciautils was just retired in Rawhide: https://src.fedoraproject.org/rpms/pcmciautils/c/24639b0 Signed-off-by: Adam Williamson <[email protected]> aarch64: Escape volid before using it s390: Escape volid before using it ltmpl: Handle installing provides with resolve_pkg_spec Previously the installpkg command used filter_match to select packages, which works great most of the time. It fails when the package is only available as a provide. This happened recently with wget moving to wget2-wget, causing builds to fail because it couldn't find wget. This changes installpkg to use the resolve_pkg_spec function, which as it happens also support globs and version comparison operators. DNF doesn't like the `==` operator, but I have retained support for it by translating it to a single `=`. I have dropped support for `=>` and `=<` since they are never used and are and odd way to specify `>=` and `>=` which of course still work. runtime-install: drop kdump-anaconda-addon I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <[email protected]> Adding anaconda-tools to the install list, maybe that's why moddep.lst doesn't exist Added 'firstboot' flag to get user to go through the install screen adding extra debug lines to try to get firstboot working docs mentioned initial-setup-gui, trying that out too mkksiso: Add support for adding an anaconda updates.img Anaconda supports an updates.img file that can be used to assist in development, the files in it are added to the boot.iso's rootfs before Anaconda is started. Use `mkksiso --updates /path/to/updates.img` to add the image to the iso. It can be used by itself or in combination with other options. It would be great way to avoid requirement for HTTP server for local development. Automatic commit of package [lorax] release [40.4-1]. Created by command: /usr/bin/tito tag Cleaned up list, grouping similar items. Added example for trying to get firstboot working fedora-livemedia.ks worked, no need for a extra ks file forgot to specify type: string, though I think this is the default anyways Added input variable to filename of iso
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.