Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefixdevname support to the boot.iso #1386

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add prefixdevname support to the boot.iso #1386

merged 1 commit into from
Mar 11, 2024

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Mar 6, 2024

Resolves: rhbz#2267227

@rvykydal rvykydal marked this pull request as draft March 6, 2024 14:06
bcl
bcl approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Tests are currently failing because the new version of python3-coveralls hasn't hit all the rawhide mirrors yet.

@rvykydal rvykydal marked this pull request as ready for review March 8, 2024 07:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8173384824

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.521%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pylorax/init.py 0 1 0.0%
Totals Coverage Status
Change from base Build 7964413895: 0.0%
Covered Lines: 1614
Relevant Lines: 3500
💛 - Coveralls

@rvykydal
Copy link
Contributor Author

@bcl I think we can merge the PR, Anaconda seems to be ready for it: https://bugzilla.redhat.com/show_bug.cgi?id=2267227#c2

@bcl bcl merged commit ffba307 into weldr:master Mar 11, 2024
2 checks passed
@sgallagher
Copy link
Contributor

When making changes to the lorax code that requires commensurate changes to the templates, it would be REALLY helpful if you could also send a merge request for https://src.fedoraproject.org/rpms/lorax-templates-rhel/

This broke our Fedora ELN composes in a non-obvious way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcl bcl bcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvykydal @coveralls @sgallagher @bcl