This repository has been archived by the owner on May 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Adding post 1990's Iorter and moving the db unit test #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to config / pytestconfig
ninpnin
reviewed
Feb 22, 2024
ninpnin
suggested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove hard-coded paths and use argparse arguments if possible
just in the scripts/stats-dashboard/mp-coverage.py, or you have something else in mind? I actually wanted to move almost everything from that stats dashboard process to the pyriksdagen module. |
I thought just here, since we make changes to it now. BTW there is a merge conflict in test/pytestconfig.py now, can you fix that? |
OK, yep, I have it open now. |
ninpnin
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here come the last iorter and an update unit test per #294
Also moved the input files for the db unittest in accordance with plans made re #329