Issue 10 #14
Merged
Issue 10 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the execFile call to specify the maxBuffer size to be tuneable and larger than 200KB. By default the plugin will now look up the current file size and allocate 2x the buffer to allow room for whitespace and formatting expansion. This also fixes the issue where the plugin could not format files that were large than 200KB. Add a new configuation option to allow a user to tune the buffer multiplier to custom values. Update documentation.
welkineins
requested changes
Mar 24, 2018
extension.js
Outdated
| @@ -25,16 +32,19 @@ class AstyleFormatter { | |||
| }); | |||
|
|
|||
| astyleBinPath = astyleBinPath.replace(/\${workspaceRoot}/g, vscode.workspace.rootPath); | |||
|
|
|||
| // Assume that the formatting/expansion of the document could double it's size | |||
| const maxBufferSize = this.getFilesizeInBytes(document.fileName) * astyleMaxBufferMultiplier; | |||
There was a problem hiding this comment.
Hi @davidritter,
Thank you very much for fixing this issue!!
After review, I think it would be better to set max buffer size at least larger than default value 200*1024.
I'll merge this PR and release new version soon later.
Thanks.
calculated new multiplier buffer size for a larger file or use the default value for execFile to avoid any pointless buffer resizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the issue described in:
#10