Skip to content
This repository has been archived by the owner on Apr 10, 2021. It is now read-only.

Normalize line endings #95

Closed
wants to merge 1 commit into from

Conversation

Shredder121
Copy link

Sorry to start off with such a big commit, but I noticed that not all line endings were normalized.

@Shredder121
Copy link
Author

It's at least a step in the right direction (to have a .gitattributes file and enforce line endings), I very much respect that, I also do it on my projects 😉

Let me know what you think.

In commit 6ac0b2d not all steps were executed
@bennycode
Copy link
Member

Hello @Shredder121 and thank you for your contribution.

We have enforced line endings: https://github.com/welovecoding/editorconfig-netbeans/blob/master/.gitattributes#L4

So what was wrong with them?

@Shredder121
Copy link
Author

Hi!
The commit that introduced the normalization(or rather the enforcement of normalization) didn't actually normalize the line endings.
Has anything changed in the meantime? I can renormalize the line endings if you want.

@Shredder121
Copy link
Author

Nothing has changed, so it should apply as-is.

@bennycode bennycode closed this May 29, 2016
@Shredder121
Copy link
Author

It's better to normalize the line endings up front, otherwise the next change applied will introduce unnecessary whitespace changes.

@Shredder121
Copy link
Author

So I take it that this change is not wanted?
When I cloned the repository initially, git said I had unstaged changes.
This will also happen to others, presumably.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants