Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the bundle wasn't working for me with Symfony 6 and PHP 8.2, so I made the fork. I think it could be connected to #31
What is done:
Symfony\Bundle\FrameworkBundle\Controller\AbstractController
instead ofSymfony\Bundle\FrameworkBundle\Controller\AbstractController\Controller
(not available in Symfony 6).Command::SUCCESS
).!=
->!==
).SubscriberEvent
andWebhookEvent
: removedSymfony\Component\EventDispatcher\Event
class (removed in Symfony 4?)type: annotation
totype: attributes
.Symfony\Component\HttpKernel\Bundle\AbstractBundle
instead ofSymfony\Component\HttpKernel\Bundle\Bundle
.TODO:
yield
could be helpful.If you decide to merge, I thing it should be major release (a'la mentioned above 2.0), there are BC changes here.
Anyway it works perfect with my app syncing ~4000 users with Mailchimp.