Skip to content

docs: edited the link to the forks shield #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Olexandr88
Copy link
Contributor

Summary

Related issue

Changes

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@Olexandr88 Olexandr88 requested a review from welpo as a code owner April 14, 2025 09:10
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit a72e485
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67fcd10ccddf670008e0f199
😎 Deploy Preview https://deploy-preview-514--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
Copy link
Owner

welpo commented Apr 14, 2025

Why do you think this is better than the current link?

@Olexandr88
Copy link
Contributor Author

Hey. I have analyzed many projects that use this badge, and almost all of them use this link that I suggested to the public.

@welpo
Copy link
Owner

welpo commented Apr 14, 2025

I think it's fine as is.

For future contributions, please read the contributing guidelines.

@welpo welpo closed this Apr 14, 2025
@Olexandr88
Copy link
Contributor Author

I think it's fine as is.

For future contributions, please read the contributing guidelines.

I want to discuss with you such a problem as the lack of a link to the badge (last commit), in my opinion it should be supplemented with the following link:
https://github.com/welpo/tabi/commits

@welpo
Copy link
Owner

welpo commented Apr 14, 2025

That sounds reasonable. I'd accept that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants