♻️ refactor: add "target_attribute" macro #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new macro name
target_attribute.html
(trying to maintain naming convention). The purpose is to improv code organization in the logic that determines thetarget="_blank"
attribute for external links.The same logic block is currently repeated in several templates:
page.html
partials/footer.html
partials/cards_pages.html
Additionally, it will also be used in
tags/singl.html
.Related issue
It isn't related to any issue but we talked about it in this discussion.
Changes
The new macro contain the following content:
This macro is imported in
base.html
:Usage in the templates:
Type of change
Checklist
theme.toml
with a sane default for the featureconfig.toml
in tabi-startconfig.toml
commentstheme.toml
comments