Esptrim #7
Open
Esptrim #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrc522.py
Outdated
| self._wreg(reg, self._rreg(reg) & (~mask)) | ||
|
|
||
| def _tocard(self, cmd, send): | ||
| OK = 0 |
There was a problem hiding this comment.
the diff looks strange because you used 4 spaces and the original code used tabs for indentation.
pep8 recommends 4 spaces, but this formatting change should not be introduced mixed into a functionality change, it makes review quite hard.
There was a problem hiding this comment.
That slipped my mind, sorry about that. I have my vim setup to auto convert tabs. I'll change the indentation so you can read it easier.
There was a problem hiding this comment.
Actually my most recent commit is using tabs instead of spaces. So if you set it to compare your master against all the commits made the changes are more legible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in updates for SPI hardware utilization for the esp8266 and corrected typo for esp baudrate to work properly