Update rotld whois #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2018 13:59
|
@weppos I can not run tests because my Mac doesn't want to install json gem. I've tested by hand and all works. Would you like to commit my pull please? |
weppos
reviewed
Jun 25, 2019
lib/whois/parsers/whois.rotld.ro.rb
Outdated
| @@ -45,13 +45,20 @@ class WhoisRotldRo < Base | |||
| !available? | |||
| end | |||
|
|
|||
| property_supported :expires_on do | |||
There was a problem hiding this comment.
Can you please keep the property definition sorted as in the previous version.
Sort property definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add expires_on and created_on