Prevent #parse_buffer
from altering input buffer
#454
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
This PR prevent
#parse_buffer
from altering input buffer.As stated in the issue, it is more intuitive for
parse_buffer
to not change the input buffer.However, the internal call
Zip::File.open_buffer
changes the input buffer if called with block.Therefore, I changed the calling method so that it does not use block.