Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the compare_objects flag in schemadiff #445

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

newborn22
Copy link
Contributor

@newborn22 newborn22 commented Feb 22, 2024

Descriptions

Add the compare_objects flag, establishing the code framework.

Now user can use --compare_objects to specify the schema objects to compare, for example:

vtctlclient --server localhost:15999 Branch -- --workflow_name branch_test --compare_objects target_snapshot schemadiff

The option of --compare_objects flag can be one of follows:
source_target, target_source, target_snapshot, snapshot_target, source_snapshot, snapshot_source

Related Issue(s)

#444

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@earayu
Copy link
Collaborator

earayu commented Feb 23, 2024

LGTM

Copy link
Contributor

@gerayking gerayking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newborn22 newborn22 merged commit f09e17c into main Feb 23, 2024
17 checks passed
@newborn22 newborn22 deleted the feature/add_compare_objects_flag_in_schemadiff branch February 23, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants