Adds support for torch MPS backend #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesselb
reviewed
Sep 10, 2023
There was a problem hiding this comment.
@magnusross thanks for much for this. :)
I think this is the right way to go about this. I've left a few comments/suggestions.
In addition, I think a unit test to test the logic here would be helpful. I could also implement that myself, if you'd like.
|
Hey Wessel, thanks for looking at this, I've fixed the suggestions, but I haven't yet done any tests, I couldn't immediately see how to do it, and am a bit busy with some other stuff right now. Happy to have a go at it later in the week! |
|
@magnusross absolutely not a problem! Happy to implement a simple test myself. I think your implementation is basically ready to go, so I'm merging this right away :) Thanks again for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the only required change is to how the random states/generators are dealt with.
I have done a bit of a hacky initial implementation, there is probably a cleaner way to do it. I didn't yet workout how to write some tests for it, but can have a go at that if needed.
Cheers!